jiajunwang commented on a change in pull request #1110:
URL: https://github.com/apache/helix/pull/1110#discussion_r443898073
##########
File path: helix-core/src/main/java/org/apache/helix/HelixPropertyFactory.java
##########
@@ -47,17 +49,30 @@ public static HelixPropertyFactory getInstance() {
* Clients may override these values.
*/
public HelixManagerProperty getHelixManagerProperty(String zkAddress, String
clusterName) {
- ConfigAccessor configAccessor = new ConfigAccessor(zkAddress);
CloudConfig cloudConfig;
- // The try-catch logic is for backward compatibility reason only. Even if
the cluster is not set
- // up yet, constructing a new ZKHelixManager should not throw an exception
+ HelixZkClient zkClient = null;
try {
- cloudConfig =
- configAccessor.getCloudConfig(clusterName) == null ?
buildEmptyCloudConfig(clusterName)
- : configAccessor.getCloudConfig(clusterName);
- } catch (HelixException e) {
- cloudConfig = buildEmptyCloudConfig(clusterName);
+ // This configAccessor is a dedicated zkclient because HelixManager is
single realm
Review comment:
Let's mention another reason we want a dedicated client instead of
shared client here is for the isolation level that we need.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
