pkuwm opened a new pull request #1117: URL: https://github.com/apache/helix/pull/1117
### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: Fixes #1116 ### Description - [ ] Here are some details about my PR, including screenshots of any UI changes: Unit test testMsgTriggeredRebalance() consistently fails, because we allow ignoring pending messages and sending ST messages when current state equals pending msg's to state. We should change the test condition a bit to allow messages number >= 1. This PR also formats the file `TestRebalancePipeline.java` ### Tests - [ ] The following tests are written for this issue: Changed `testMsgTriggeredRebalance` - [ ] The following is the result of the "mvn test" command on the appropriate module: Only fix the test so just run and pass the single test. ``` END testMsgTriggeredRebalance at Tue Jun 23 01:54:12 PDT 2020, took: 7861ms. Shut down zookeeper at port 2183 in thread main =============================================== Default Suite Total tests run: 1, Failures: 0, Skips: 0 =============================================== ``` ### Commits - [ ] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation (Optional) - [ ] In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Code Quality - [ ] My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
