jiajunwang commented on a change in pull request #1119:
URL: https://github.com/apache/helix/pull/1119#discussion_r444641521
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java
##########
@@ -1172,13 +1176,32 @@ private void fireNewSessionEvents() {
}
final String sessionId = getHexSessionId();
for (final IZkStateListener stateListener : _stateListener) {
- _eventThread.send(new ZkEventThread.ZkEvent("New session event sent to "
+ stateListener, sessionId) {
+ _eventThread
+ .send(new ZkEventThread.ZkEvent("New session event sent to " +
stateListener, sessionId) {
- @Override
- public void run() throws Exception {
- stateListener.handleNewSession(sessionId);
- }
- });
+ @Override
+ public void run() throws Exception {
+ if (_syncOnNewSession) {
Review comment:
Please extract a method for sync.
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java
##########
@@ -1172,13 +1176,32 @@ private void fireNewSessionEvents() {
}
final String sessionId = getHexSessionId();
for (final IZkStateListener stateListener : _stateListener) {
- _eventThread.send(new ZkEventThread.ZkEvent("New session event sent to "
+ stateListener, sessionId) {
+ _eventThread
+ .send(new ZkEventThread.ZkEvent("New session event sent to " +
stateListener, sessionId) {
- @Override
- public void run() throws Exception {
- stateListener.handleNewSession(sessionId);
- }
- });
+ @Override
+ public void run() throws Exception {
+ if (_syncOnNewSession) {
+ //System.out.println("syncOnNewSession with sessionID:" +
sessionId);
+ LOG.info("syncOnNewSession with sessionId {}", sessionId);
+ final ZkConnection zkConnection = (ZkConnection)
getConnection();
+ if (zkConnection == null || zkConnection.getZookeeper() ==
null) {
+ throw new IllegalStateException(
+ "ZkConnection is in invalid state! Please close this
ZkClient and create new client.");
+ }
+ final String syncPath = new String("/");
+ zkConnection.getZookeeper().sync(syncPath, new
AsyncCallback.VoidCallback() {
+ @Override
+ public void processResult(int rt, String s, Object ctx) {
+ //System.out.println("sycnOnNewSession with sessionID " +
sessionId + " async return code:" + rt);
Review comment:
remove
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java
##########
@@ -185,6 +188,7 @@ protected ZkClient(IZkConnection zkConnection, int
connectionTimeout, long opera
if (zkConnection == null) {
throw new NullPointerException("Zookeeper connection is null!");
}
+ _syncOnNewSession = true;
Review comment:
You mentioned we will have more changes here. Will we make it optional?
If so, I think we should have the change in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
