jiajunwang opened a new pull request #1123: URL: https://github.com/apache/helix/pull/1123
### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: (#200 - Link your issue number here: You can write "Fixes #XXX") ### Description - [ ] Here are some details about my PR, including screenshots of any UI changes: This is to prevent the WAGED rebalancer reads stale assignment records from the previous rebalance pipeline. For example, 1. Resource A was the only resource. And it is rebalanced by WAGED, then we have a persisted assignment for A. 2. Resource A was reconfigured to using DelayedRebalancer, then we stop the WAGED rebalancer since there is no more resource using WAGED. So the persisted records are still in ZK. 3. Resource A is recreated and using WAGED again. In this case, the previous persisted assignment is no longer valid. We should treat A as a brand new resource instead of considering the stale assignment record. Moreover, this change will help to clean up the ZK persisted data if no resource is using WAGED. ### Tests - [X] The following tests are written for this issue: TestAssignmentMetadataStore, TestWagedRebalancer - [ ] The following is the result of the "mvn test" command on the appropriate module: running ### Commits - [X] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation (Optional) - [ ] In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Code Quality - [X] My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
