alirezazamani opened a new pull request #1131: URL: https://github.com/apache/helix/pull/1131
### Issues - [x] My PR addresses the following Helix issues and references them in the PR title: Fixes #1099 Fixes #1130 ### Description - [x] Here are some details about my PR, including screenshots of any UI changes: In this commit, the znode version has been used to create the RuntimeJobDag in order to avoid race condition between purge logic and cache refresh. This PR specifically stabilized TestJobQueueCleanUp. Also this PR allows the job to continue running even if its IdealState has been removed. ### Tests - [x] The following tests are written for this issue: TestJobQueueDeleteIdealState - [x] The following is the result of the "mvn test" command on the appropriate module: helix-core: ``` [INFO] Results: [INFO] [ERROR] Failures: [ERROR] TestClusterVerifier.testResourceSubset:225 expected:<false> but was:<true> [INFO] [ERROR] Tests run: 1149, Failures: 1, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:19 h [INFO] Finished at: 2020-06-29T13:13:43-07:00 [INFO] ------------------------------------------------------------------------ ``` The failed test succeeded when run individually. mvn test -Dtest="TestClusterVerifier" ``` [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 32.64 s - in org.apache.helix.tools.TestClusterVerifier [INFO] [INFO] Results: [INFO] [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 38.336 s [INFO] Finished at: 2020-06-29T13:36:52-07:00 [INFO] ------------------------------------------------------------------------ ``` helix-rest: ``` [INFO] Tests run: 163, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 41.702 s - in TestSuite [INFO] [INFO] Results: [INFO] [INFO] Tests run: 163, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 46.846 s [INFO] Finished at: 2020-06-29T13:39:55-07:00 [INFO] ------------------------------------------------------------------------ ``` ### Commits - [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - [x] My diff has been formatted using helix-style.xml ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
