jiajunwang commented on pull request #1138: URL: https://github.com/apache/helix/pull/1138#issuecomment-657793829
> Twe question/comments: > > 1/ Is this inclusive for closing all these objects to prevent leaking zookeeper client? > > 2/ relying on finalized means that the objects are only closed when GC happens. This is not ideal. I understand we want a quick fix for now. Will enhance it later. 1. this is not inclusive. Just a quick fix. Even during the test, I notice there are lots of more leakage. 2. You are right. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
