jiajunwang commented on a change in pull request #1124:
URL: https://github.com/apache/helix/pull/1124#discussion_r454118361
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/dataproviders/BaseControllerDataProvider.java
##########
@@ -544,6 +544,13 @@ public synchronized void
setLiveInstances(List<LiveInstance> liveInstances) {
return _instanceMessagesCache.getMessages(instanceName);
}
+ public void setStaleMessages(Map<String, Map<String, Message>>
staleMessageMap) {
Review comment:
This is never called? Or there are some other changes that you haven't
pushed?
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/CurrentStateComputationStage.java
##########
@@ -56,11 +57,17 @@
*/
public class CurrentStateComputationStage extends AbstractBaseStage {
private static Logger LOG =
LoggerFactory.getLogger(CurrentStateComputationStage.class);
+ private boolean isTaskFrameworkPipeline = false;
Review comment:
nit, _ isTaskFrameworkPipeline
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
