jiajunwang commented on a change in pull request #1149:
URL: https://github.com/apache/helix/pull/1149#discussion_r455976607
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java
##########
@@ -866,6 +858,83 @@ public void disconnect() {
}
}
+ /**
+ * The callback handler cleanup operations that require an active ZkClient
connection.
Review comment:
1. we subscribe, and the subscription requires ZK connection.
2. Some of our Helix callback handler implementations will read ZK even for
finalizing.
3. There is no way to prevent any customer-defined handler logic to access
ZK for finalizing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
