rabashizade opened a new pull request #1169: URL: https://github.com/apache/helix/pull/1169
### Issues - [ x] My PR addresses the following Helix issues and references them in the PR description: Fixes #1168 ### Description - [x ] Here are some details about my PR, including screenshots of any UI changes: In this PR, loadNewTask() method is added to TaskStateModel to dynamically load tasks that are not already defined in task factory registry. This prevents the need to implement task-specific Participants and thus, enables numerous use cases with minimal extra coding effort beyond implementing the task logic itself. ### Tests - [ x] The following tests are written for this issue: TestDynamicTaskLoading - [ x] The following is the result of the "mvn test" command on the appropriate module: [INFO] Results: [INFO] [ERROR] Failures: [ERROR] TestEnableCompression.testEnableCompressionResource:117 expected:<true> but was:<false> [ERROR] TestP2PNoDuplicatedMessage.testP2PStateTransitionEnabled:175 Only 415 out of 704 percent transitions to Master were triggered by expected host! expected:<true> but was:<false> [ERROR] TestWagedRebalance.testChangeIdealState:303->validate:646 expected:<true> but was:<false> [ERROR] TestJobFailureDependence.testWorkflowFailureJobThreshold » ThreadTimeout Metho... [ERROR] TestClusterStateVerifier.afterMethod:98 » IllegalState ZkClient already closed... [ERROR] TestClusterVerifier.testResourceSubset:225 expected:<false> but was:<true> [INFO] [ERROR] Tests run: 1156, Failures: 6, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary for Apache Helix 1.0.2-SNAPSHOT: [INFO] [INFO] Apache Helix ....................................... SUCCESS [ 0.563 s] [INFO] Apache Helix :: Metrics Common ..................... SUCCESS [ 3.421 s] [INFO] Apache Helix :: Metadata Store Directory Common .... SUCCESS [ 2.242 s] [INFO] Apache Helix :: ZooKeeper API ...................... SUCCESS [ 53.690 s] [INFO] Apache Helix :: Helix Common ....................... SUCCESS [ 1.298 s] [INFO] Apache Helix :: Core ............................... FAILURE [ 01:17 h] [INFO] Apache Helix :: Admin Webapp ....................... SKIPPED [INFO] Apache Helix :: Restful Interface .................. SKIPPED [INFO] Apache Helix :: Distributed Lock ................... SKIPPED [INFO] Apache Helix :: HelixAgent ......................... SKIPPED [INFO] Apache Helix :: Recipes ............................ SKIPPED [INFO] Apache Helix :: Recipes :: Rabbitmq Consumer Group . SKIPPED [INFO] Apache Helix :: Recipes :: Rsync Replicated File Store SKIPPED [INFO] Apache Helix :: Recipes :: distributed lock manager SKIPPED [INFO] Apache Helix :: Recipes :: distributed task execution SKIPPED [INFO] Apache Helix :: Recipes :: service discovery ....... SKIPPED [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:18 h [INFO] Finished at: 2020-07-23T17:56:53-07:00 [INFO] ------------------------------------------------------------------------ ### Commits - [ x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - [x ] My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
