pkuwm commented on a change in pull request #1190:
URL: https://github.com/apache/helix/pull/1190#discussion_r463477490
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/server/resources/zookeeper/ZooKeeperAccessor.java
##########
@@ -52,12 +51,15 @@
private static final Logger LOG =
LoggerFactory.getLogger(ZooKeeperAccessor.class.getName());
private BaseDataAccessor<byte[]> _zkBaseDataAccessor;
+ private static final String PATH_STR = "path";
+
public enum ZooKeeperCommand {
exists,
getBinaryData,
getStringData,
getChildren,
- getStat
+ getStat,
+ delete
Review comment:
My opinion is,
1. use `DELETE` verb that is designed for the REST delete operation.
2. if we only want to support deleting ephemeral, document it well and
return a clear response like:
```
HTTP/1.1 404
Content-Type: application/json
{
"message": "Deleting a non-ephemeral node is not supported/allowed",
"path": "/a/b/c"
}
```
And it is extensible if we want to support deleting persistent node in the
future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
