narendly commented on a change in pull request #1208:
URL: https://github.com/apache/helix/pull/1208#discussion_r464773385
##########
File path: helix-core/src/main/java/org/apache/helix/task/TaskConstants.java
##########
@@ -49,4 +49,24 @@
public static final String PREV_RA_NODE = "PreviousResourceAssignment";
public static final boolean DEFAULT_TASK_ENABLE_COMPRESSION = false;
+ /**
+ * Name of the JAR file for the task dynamically loaded in {@link
TaskStateModel}
+ */
+ public static final String TASK_JAR_FILE_KEY = "JAR_FILE";
+ /**
+ * Version of the task dynamically loaded in {@link TaskStateModel}
+ */
+ public static final String TASK_VERSION_KEY = "VERSION";
+ /**
+ * Name of the {@link Task} class(es) for the task dynamically loaded in
{@link TaskStateModel}
+ */
+ public static final String TASK_CLASSES_KEY = "TASK_CLASSES";
+ /**
+ * Name of the {@link TaskFactory} class for the task dynamically loaded in
{@link TaskStateModel}
+ */
+ public static final String TASK_FACTORY_KEY = "TASKFACTORY";
+ /**
+ * The path for dynamic task configs
+ */
+ public static final String TASK_PATH = "/TASK_DEFINITION";
Review comment:
Let's rename TASK_PATH to DYNAMICALLY_LOADED_TASK_PATH or something.
TASK_PATH might add confusion because we actually use
/PROPERTYSTORE/TaskRebalancer/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
