kaisun2000 commented on a change in pull request #1185:
URL: https://github.com/apache/helix/pull/1185#discussion_r465434704
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java
##########
@@ -215,13 +218,21 @@ protected ZkClient(IZkConnection zkConnection, int
connectionTimeout, long opera
throw new NullPointerException("Zookeeper connection is null!");
}
+ _uid = UID.getAndIncrement();
+ if (LOG.isInfoEnabled()) {
+ LOG.info("ZkClient created with _uid {}, stacktrace {}", _uid,
Thread.currentThread().getStackTrace());
Review comment:
There are many time when I debugged, I wish to know where the zkclient
is created when I look at the zkclient event thread logs. I think this is
actually very useful. In fact, I would event want to add the _uid to each line
of logs from Zkclient. It would save a lot time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
