jiajunwang commented on a change in pull request #1201:
URL: https://github.com/apache/helix/pull/1201#discussion_r465921998
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
##########
@@ -1272,7 +1280,7 @@ protected void
checkLiveInstancesObservation(List<LiveInstance> liveInstances,
public void shutdown() throws InterruptedException {
stopPeriodRebalance();
-
+ stopOnDemandTimer();
Review comment:
In theory, if a FINALIZE notification comes, then we should stop any
pending tasks. Or it will keep running even without the later INIT notification
comes.
But I agree that this PR won't make it worse. We can skip that change for
now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
