kaisun2000 opened a new pull request #1227:
URL: https://github.com/apache/helix/pull/1227
Implement thread leakage check for each test class #1226 #1226
- [x] My PR addresses the following Helix issues and references them in the
PR description:
resolve #1226
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
Recently unit test can not complete due to threads leaking
and ZK session leaking. We identified the leaks and fixed
them. In order for future test not to leak resources, we
need a way to enforce test class would release/clean up resource created
during test.
A check is implemented in @afterclass in ZkTestBase.java.
### Tests
- [ ] The following tests are written for this issue:
- [ ] The following is the result of the "mvn test" command on the
appropriate module:
(Before CI test pass, please copy & paste the result of "mvn test")
running
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following
wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their
subject lines. In addition, my commits follow the guidelines from "[How to
write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
