rabashizade opened a new pull request #1229:
URL: https://github.com/apache/helix/pull/1229


   ### Issues
   
   - [x] My PR addresses the following Helix issues and references them in the 
PR description:
   
   Fixes #1228 
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI 
changes:
   
   This PR adds JarLoader interface and LocalJarLoader class which implements 
this interface to load JAR files that contain task classes which we want to 
dynamically load in the Participant.
   
   ### Tests
   
   - [ ] The following tests are written for this issue:
   
   No tests were written, as this PR only adds an interface and a class to the 
project.
   
   - [x] The following is the result of the "mvn test" command on the 
appropriate module:
   
   Since the PR doesn't modify any existing code, it's not going to cause any 
test failures. The following is the build result:
   
   ```
   [INFO] 
------------------------------------------------------------------------
   [INFO] Reactor Summary for Apache Helix 1.0.2-SNAPSHOT:
   [INFO] 
   [INFO] Apache Helix ....................................... SUCCESS [  2.936 
s]
   [INFO] Apache Helix :: Metrics Common ..................... SUCCESS [  3.749 
s]
   [INFO] Apache Helix :: Metadata Store Directory Common .... SUCCESS [  2.363 
s]
   [INFO] Apache Helix :: ZooKeeper API ...................... SUCCESS [  5.089 
s]
   [INFO] Apache Helix :: Helix Common ....................... SUCCESS [  3.137 
s]
   [INFO] Apache Helix :: Core ............................... SUCCESS [ 36.918 
s]
   [INFO] Apache Helix :: Admin Webapp ....................... SUCCESS [  6.789 
s]
   [INFO] Apache Helix :: Restful Interface .................. SUCCESS [ 11.578 
s]
   [INFO] Apache Helix :: Distributed Lock ................... SUCCESS [  1.888 
s]
   [INFO] Apache Helix :: HelixAgent ......................... SUCCESS [  2.996 
s]
   [INFO] Apache Helix :: Recipes ............................ SUCCESS [  0.038 
s]
   [INFO] Apache Helix :: Recipes :: Rabbitmq Consumer Group . SUCCESS [  1.241 
s]
   [INFO] Apache Helix :: Recipes :: Rsync Replicated File Store SUCCESS [  
1.386 s]
   [INFO] Apache Helix :: Recipes :: distributed lock manager  SUCCESS [  1.019 
s]
   [INFO] Apache Helix :: Recipes :: distributed task execution SUCCESS [  
1.131 s]
   [INFO] Apache Helix :: Recipes :: service discovery ....... SUCCESS [  1.058 
s]
   [INFO] 
------------------------------------------------------------------------
   [INFO] BUILD SUCCESS
   [INFO] 
------------------------------------------------------------------------
   [INFO] Total time:  01:24 min
   [INFO] Finished at: 2020-08-07T07:52:04-07:00
   [INFO] 
------------------------------------------------------------------------
   ```
   
   ### Documentation (Optional)
   
   - In case of new functionality, my PR adds documentation in the following 
wiki page:
   
   ### Commits
   
   - My commits all reference appropriate Apache Helix GitHub issues in their 
subject lines. In addition, my commits follow the guidelines from "[How to 
write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - My diff has been formatted using helix-style.xml 
   (helix-style-intellij.xml if IntelliJ IDE is used)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to