[GitHub] [helix] xyuanlu edited a comment on issue #401: Replace org.codehaus.jackson with FasterXML/jackson

[GitBox]

xyuanlu edited a comment on issue #401:
URL: https://github.com/apache/helix/issues/401#issuecomment-673767209


   Hi @brunnsbe,
   
   Thanks so much for working on Helix! 
   We did a performance experiment profile and find for a specific use case -- 
Helix controller leadership switch, using FasterXML/jackson along with some 
other performance improv changes, we get round around ~3x faster performance 
result. 
   
   Baseline profile:
   The 
org.apache.helix.zookeeper.datamodel.serializer.ZNRecordSerializer.deserialize 
took ~60% of the time for 
org.apache.helix.manager.zk.DistributedLeaderElection.onControllerChange, where 
onControllerChange overall takes ~60s. This function call is CPU heavy. 
   <img width="1389" alt="screen_shot_2020-08-07_at_12 30 15_pm" 
src="https://user-images.githubusercontent.com/6392021/90198327-37d0ac00-dd86-11ea-82c8-b9e7f4d453fa.png";>
   
   
   After changing to FasterXML/jackson and made the ObjectMapper static, 
ZNRecordSerializer.deserialize only take ~10% of the total time, where 
onControllerChange overall takes ~20s. It becomes IO bounded.
   <img width="1679" alt="Screen Shot 2020-08-13 at 5 00 29 PM" 
src="https://user-images.githubusercontent.com/6392021/90198442-80886500-dd86-11ea-9250-ba67268c4a04.png";>
   
   It is another evidence that we should replace org.codehaus.jackson with 
FasterXML/jackson.
   Xiaoyuan
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org