kaisun2000 commented on issue #1282:
URL: https://github.com/apache/helix/issues/1282#issuecomment-674488136
Still have
> 2020-08-16T06:11:19.8375558Z [ERROR]
TestClusterInMaintenanceModeWhenReachingOfflineInstancesLimit.testWithOfflineInstancesLimit:164
expected:<true> but was:<false>
with previous test adding
```
ZkHelixClusterVerifier clusterVerifier =
new
BestPossibleExternalViewVerifier.Builder(CLUSTER_NAME).setZkClient(_gZkClient).build();
Thread.sleep(100);
Assert.assertTrue(clusterVerifier.verifyByPolling());
@Test(dependsOnMethods = "testWithDisabledInstancesLimit")
public void testWithOfflineInstancesLimit() throws Exception {
MaintenanceSignal maintenanceSignal =
_dataAccessor.getProperty(_dataAccessor.keyBuilder().maintenance());
Assert.assertNull(maintenanceSignal); ---> failure
```
Change to Thread.sleep from 200 to 2000.
Consider add a default sleep period in
ZkHelixClusterVerifier.verifyByPolling().
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
