NealSun96 opened a new pull request #1330:
URL: https://github.com/apache/helix/pull/1330
### Issues
- [x] My PR addresses the following Helix issues and references them in the
PR description:
Resolves #972, #1008, #1010 Fixes #1320
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
New feature: task framework now allows task thread pools to have
configurable sizes. Users can specify target task pool sizes on either the
cluster-level or on the instance-level by setting either
GLOBAL_TARGET_TASK_THREAD_POOL_SIZE in ClusterConfig or
TARGET_TASK_THREAD_POOL_SIZE in InstanceConfig. This specification propagates
downwards, where instance-level configs overwrite the cluster-level configs,
and not specifying a value on either level defaults to the old static value of
40 - this also makes this feature backward compatible. After JVM restart, an
instance will have a pool with the specified size for task threads.
This is a combination PR of #973, #1009, #1011, #1327.
### Tests
- [x] The following tests are written for this issue:
TestParticipantManager.testCurrentTaskThreadPoolSizeCreation,
TestClusterConfig.testGetGlobalTargetTaskThreadPoolSize,
TestClusterConfig.testSetGlobalTargetTaskThreadPoolSize,
TestClusterConfig.testSetGlobalTargetTaskThreadPoolSizeIllegalArgument,
TestInstanceConfig.testGetTargetTaskThreadPoolSize,
TestInstanceConfig.testSetTargetTaskThreadPoolSize,
TestInstanceConfig.testSetTargetTaskThreadPoolSizeIllegalArgument,
(TestZKLiveInstanceData renamed to
TestLiveInstance)TestLiveInstance.testGetCurrentTaskThreadPoolSize,
TestLiveInstance.testGetCurrentTaskThreadPoolSizeDefault,
TestLiveInstance.testSetCurrentTaskThreadPoolSize, TestTaskDriver,
TestTaskStateModelFactory, TestTaskUtil.testGetTaskThreadPoolSize,
TestTaskUtil.testGetTaskThreadPoolSizeInstanceConfigUndefined,
TestTaskUtil.testGetTaskThreadPoolSizeInstanceConfigDoesNotExist,
TestTaskUtil.testGetTaskThreadPoolSizeClusterConfigUndefined,
TestTaskUtil.testGetTaskThreadPoolSizeClusterConfigDoesNotExist
- [x] The following is the result of the "mvn test" command on the
appropriate module:
```
[ERROR] Tests run: 1199, Failures: 2, Errors: 0, Skipped: 1, Time elapsed:
4,251.44 s <<< FAILURE! - in TestSuite
[ERROR]
testEnableCompressionResource(org.apache.helix.integration.TestEnableCompression)
Time elapsed: 142.226 s <<< FAILURE!
java.lang.AssertionError: expected:<true> but was:<false>
at
org.apache.helix.integration.TestEnableCompression.testEnableCompressionResource(TestEnableCompression.java:117)
[ERROR]
testPeriodicRefresh(org.apache.helix.integration.spectator.TestRoutingTableProviderPeriodicRefresh)
Time elapsed: 2.017 s <<< FAILURE!
java.lang.AssertionError: expected:<4> but was:<3>
at
org.apache.helix.integration.spectator.TestRoutingTableProviderPeriodicRefresh.testPeriodicRefresh(TestRoutingTableProviderPeriodicRefresh.java:211)
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] TestEnableCompression.testEnableCompressionResource:117
expected:<true> but was:<false>
[ERROR] TestRoutingTableProviderPeriodicRefresh.testPeriodicRefresh:211
expected:<4> but was:<3>
[INFO]
[ERROR] Tests run: 1199, Failures: 2, Errors: 0, Skipped: 1
[INFO]
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 01:11 h
[INFO] Finished at: 2020-08-28T10:58:35-07:00
[INFO]
------------------------------------------------------------------------
```
Rerun
```
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
29.928 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 35.399 s
[INFO] Finished at: 2020-08-28T11:40:53-07:00
```
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their
subject lines. In addition, my commits follow the guidelines from "[How to
write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
