pkuwm commented on a change in pull request #1342:
URL: https://github.com/apache/helix/pull/1342#discussion_r482622803
##########
File path:
helix-core/src/main/java/org/apache/helix/util/InstanceValidationUtil.java
##########
@@ -159,12 +159,14 @@ public static boolean hasValidConfig(HelixDataAccessor
dataAccessor, String clus
PropertyKey.Builder keyBuilder = dataAccessor.keyBuilder();
ClusterConfig clusterConfig =
dataAccessor.getProperty(keyBuilder.clusterConfig());
if (clusterConfig == null) {
- throw new HelixException("Cluster config is missing in cluster " +
clusterId);
+ _logger.error("Cluster config is missing in cluster " + clusterId);
+ return false;
}
if (!clusterConfig.isPersistIntermediateAssignment()) {
- throw new HelixException(String.format(
+ _logger.error(String.format(
Review comment:
Remove `String.format`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
