xyuanlu commented on a change in pull request #1344:
URL: https://github.com/apache/helix/pull/1344#discussion_r482792770
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java
##########
@@ -646,10 +645,9 @@ private void subscribeForChanges(NotificationContext.Type
callbackType, String p
break;
}
default: {
- List<String> childNames = _zkClient.getChildren(path);
- if (childNames != null) {
- for (String childName : childNames) {
- String childPath = path + "/" + childName;
+ if (children != null) {
Review comment:
There is a slightly behavior difference here. Originally before this
change, if type is Finalize, we still iterate trough all node and do
`subscribeDataChange `.
Now we do not return a children list when finalize (line 565) so we do not
do `subscribeDataChange` for those nodes.
This behavior difference cause unit test `TestListenerCallbackBatchMode`
fail on my side. Did you run in to this problem?
Thx.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
