jiajunwang edited a comment on pull request #1328: URL: https://github.com/apache/helix/pull/1328#issuecomment-691374998
> This diff is approve, please help to merge into trunk. > > > TestBestPossibleExternalViewVerifier would have a default COOL_DOWN period > > before verifyByPolling. Due to #526, currently we have randow sleep in the > > test before verifyByPolling. We intend to use TestBestPossibeVerifier > > instead in our unit test. While keep using BestPossibleExternalViewVerifier > > in production code. @kaisun2000 please update the comment, it has diverged from the code change quite a lot. Please do take care of the final comment message, once it is in, we don't have a way to modify except reverting the PR. There are good reasons that we request the author to confirm the final message, instead of just copy-paste from the PR description. And the author should not copy-paste either. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
