jiajunwang commented on a change in pull request #1357:
URL: https://github.com/apache/helix/pull/1357#discussion_r488305033
##########
File path: helix-core/helix-core-1.0.2-SNAPSHOT.ivy
##########
@@ -62,7 +62,7 @@ under the License.
<dependency org="com.google.guava" name="guava" rev="15.0"
conf="compile->compile(default);runtime->runtime(default);default->default"/>
<dependency org="org.yaml" name="snakeyaml" rev="1.12"
conf="compile->compile(default);runtime->runtime(default);default->default"/>
<dependency org="commons-logging" name="commons-logging-api" rev="1.1"
conf="compile->compile(*),master(*);runtime->runtime(*)"/>
- <dependency org="io.dropwizard.metrics" name="metrics-core" rev="3.2.3"
conf="compile->compile(default);runtime->runtime(default);default->default"/>
+ <dependency org="io.dropwizard.metrics" name="metrics-core" rev="4.1.11"
conf="compile->compile(default);runtime->runtime(default);default->default"/>
Review comment:
Can 4.1.12 work as we discussed offline?
##########
File path: helix-rest/pom.xml
##########
@@ -154,6 +154,17 @@
<type>test-jar</type>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>io.dropwizard.metrics</groupId>
+ <artifactId>metrics-jersey2</artifactId>
+ <version>4.1.11</version>
Review comment:
Why we need these dependencies in the other modules (helix-core and
metric-core)? I assume we are just going to use it for helix-rest, no?
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/server/HelixRestObjectNameFactory.java
##########
@@ -0,0 +1,86 @@
+package org.apache.helix.rest.server;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.Hashtable;
+import javax.management.MalformedObjectNameException;
+import javax.management.ObjectName;
+
+import com.codahale.metrics.jmx.ObjectNameFactory;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Creates an {@link ObjectName} that has "name", "type", "namespace"
properties
+ * for metrics registry in Helix rest service.
+ *
+ * <p>It is recommended to only be used within Helix REST.
+ */
+class HelixRestObjectNameFactory implements ObjectNameFactory {
+ private static final Logger LOG =
LoggerFactory.getLogger(HelixRestObjectNameFactory.class);
+
+ private static final String KEY_NAME = "name";
+ private static final String KEY_TYPE = "type";
+ private static final String KEY_NAMESPACE = "namespace";
+
+ public ObjectName createName(String type, String domainNameSpace, String
name) {
+ String[] splits = domainNameSpace.split(":");
+ String domain = splits[0];
+ String namespace = splits[1];
+
+ try {
+ Hashtable<String, String> properties = new Hashtable<>();
+ properties.put(KEY_NAME, name);
+ properties.put(KEY_TYPE, type);
+ properties.put(KEY_NAMESPACE, namespace);
+
+ /*
+ * The only way we can find out if we need to quote the properties is by
Review comment:
Given this is an internally used class, do we expect any value that
needs quote?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
