zhangmeng916 commented on a change in pull request #1307:
URL: https://github.com/apache/helix/pull/1307#discussion_r489577867
##########
File path: helix-core/src/main/java/org/apache/helix/HelixAdmin.java
##########
@@ -420,6 +420,24 @@ void addStateModelDef(String clusterName, String
stateModelDef, StateModelDefini
*/
void removeCloudConfig(String clusterName);
+ /**
+ * Get the topology of a specific cluster
+ * @param clusterName
+ */
+ Map<String, List<String>> getAllTopology(String clusterName);
+
+ /**
+ * Get all the instances under the fault zone
+ * @param clusterName
+ */
+ Map<String, List<String>> getInstancesUnderFaultZone(String clusterName);
+
+ /**
+ * Get all the instances whose domain config is not valid
+ * @param clusterName
+ */
+ List<String> getInvalidInstances(String clusterName);
+
Review comment:
If we return an object, users will still need to parse it by themselves.
It's a lot of work if you look at the functions in ClusterTrie. I don't think
we want to have this requirement on them. Or you mean users need to call the
functions inside ClusterTrie? then they need to know all the available
functions? Please let me know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]