kaisun2000 commented on issue #1299:
URL: https://github.com/apache/helix/issues/1299#issuecomment-693818817


   second issue:
   
   >2020-09-17T03:50:18.5157922Z [ERROR] 
test(org.apache.helix.integration.TestDisableCustomCodeRunner)  Time elapsed: 
3.475 s  <<< FAILURE!
   2020-09-17T03:50:18.5159810Z java.lang.AssertionError: expected:<false> but 
was:<true>
   2020-09-17T03:50:18.5161652Z         at 
org.apache.helix.integration.TestDisableCustomCodeRunner.test(TestDisableCustomCodeRunner.java:236)
   2020-09-17T03:50:18.5163211Z 
   2020
   
   
   code:
   ```
     for (String instance : callbacks.keySet()) {
         DummyCallback callback = callbacks.get(instance);
         if (instance.equals(leader)) {
           Assert.assertTrue(callback.isInitTypeInvoked());
         } else {
           Assert.assertFalse(callback.isInitTypeInvoked());  --> 
         }
         callback.reset();
   
   ```
   
   The question boils down why the assertion should be right? Let us disable it 
for now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to