pkuwm opened a new pull request #1377: URL: https://github.com/apache/helix/pull/1377
### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: Resolves #1376 ### Description - [ ] Here are some details about my PR, including screenshots of any UI changes: We need a jmx reporter that is lightweight and easy to use for helix rest. The PR implements a `JmxReporter` class that is based on Dropwizard Metrics lib's [`JmxReporter`](https://github.com/dropwizard/metrics/blob/master/metrics-core/src/main/java/io/dropwizard/metrics/JmxReporter.java) class. Some changes are applied: * Add `withKeyProperties()` to builder so we can add more key properties to an object name * Remove the `ObjectNameFactory` and put the simple logic to the internal `createName()` * Fix and add unit tests ### Tests - [ ] The following tests are written for this issue: * TestJmxReporter - [ ] The following is the result of the "mvn test" command on the appropriate module: ``` [INFO] Tests run: 175, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 39.013 s - in TestSuite [INFO] [INFO] Results: [INFO] [INFO] Tests run: 175, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 45.352 s [INFO] Finished at: 2020-09-17T21:16:58-07:00 [INFO] ------------------------------------------------------------------------ ``` ### Documentation (Optional) - In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Commits - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
