NealSun96 opened a new pull request #1413: URL: https://github.com/apache/helix/pull/1413
### Issues - [x] My PR addresses the following Helix issues and references them in the PR description: Fixes #1412 ### Description - [x] Here are some details about my PR, including screenshots of any UI changes: As described in the issue, we would like to avoid the scenario where nodes that have been offline for a while come back to life during maintenance mode. Solution: if a node has been offline for a certain period of time, the maintenance mode rebalancer will not assign partitions to it. To accomplish this, two aspects of changes are necessary: 1. A new customer-defined value is required to enable this feature: MAINTENANCE_NODE_TIME_OUT. This value represents "how long a node has been offline such that it should be timed out". This value is set in ClusterConfig, similar to DELAY_REBALANCE_TIME. 2. A new logic should be added to the refreshLiveInstances() function of BaseControllerDataProvider. When the maintenance mode is enabled, find the new live nodes, and filter out the timed-out nodes; the timed-out nodes are treated as not live throughout the pipeline. ### Tests - [x] The following tests are written for this issue: Everything under: TestParticipantHistory.java, TestOfflineNodeTimeoutDuringMaintenanceMode.java testGetMaintenanceOfflineNodeTimeOut(), testSetMaintenanceOfflineNodeTimeOut() - [ ] The following is the result of the "mvn test" command on the appropriate module: (Before CI test pass, please copy & paste the result of "mvn test") ### Documentation (Optional) - In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Commits - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
