NealSun96 commented on a change in pull request #1413:
URL: https://github.com/apache/helix/pull/1413#discussion_r496292698
##########
File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java
##########
@@ -122,7 +122,13 @@
// don't specify their individual pool sizes, this value will be used for
all participants; if
// none of participants or the cluster define pool sizes,
// TaskConstants.DEFAULT_TASK_THREAD_POOL_SIZE will be used to create pool
sizes.
- GLOBAL_TARGET_TASK_THREAD_POOL_SIZE
+ GLOBAL_TARGET_TASK_THREAD_POOL_SIZE,
+
+ // The time out window for offline nodes during maintenance mode; if an
offline node has been
+ // offline for more than this specified time period, it's treated as
offline for the rest of
+ // the maintenance mode's duration even when it comes online.
+ // The unit is milliseconds.
+ MAINTENANCE_OFFLINE_NODE_TIME_OUT
Review comment:
Sure, but wouldn't that be too long? I don't know the convention about
variable length, so I took a shorter version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
