pkuwm commented on a change in pull request #1383:
URL: https://github.com/apache/helix/pull/1383#discussion_r496592849
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/common/HelixDataAccessorWrapper.java
##########
@@ -54,15 +60,30 @@
public static final String IS_HEALTHY_KEY = "IS_HEALTHY";
public static final String EXPIRY_KEY = "EXPIRE";
+ // Metric names for custom partition check
+ private static final String CUSTOM_PARTITION_CHECK_HTTP_REQUESTS_TOTAL =
+ MetricRegistry.name(InstanceService.class,
"custom_partition_check_http_requests_total");
Review comment:
Helix-core is using keyword `Counter`/`Gauge` to represent the metric
type. Either works. I'd like more inserting the type into object name, if we
expect users to parse object names in mbean server. And it gives more
flexibility/space to name a metric without Counter/Gauge. It can also be
"time", "latency", "total", "requests_queued", etc..
More easily and concisely, I would suggest we can have a centralized metrics
exposed to users so users can use the metrics class to get helix metrics.
```
HelixRestMetrics { // or HelixCoreMetrics
public final Counter custom_call_request;
public final Gauge request_latency;
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
