kaisun2000 commented on a change in pull request #1066:
URL: https://github.com/apache/helix/pull/1066#discussion_r499084334
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
##########
@@ -1360,6 +1369,8 @@ private boolean updateControllerState(NotificationContext
changeContext, PauseSi
String uid = UUID.randomUUID().toString().substring(0, 8);
ClusterEvent event = new ClusterEvent(_clusterName,
ClusterEventType.Resume,
String.format("%s_%s", uid, Pipeline.Type.DEFAULT.name()));
+ event.addAttribute(AttributeName.EVENT_SESSION.name(),
+ changeContext.getManager().getSessionIdIfLead());
Review comment:
@pkuwm , here is the thing. If say when pause signal znode is added, the
under old session S0, the event is put into zkclient queue. Then a new session
establish for S1, would the controller under S1 for this logic, would not pause
of the old event.
The question is that can you double check if the new session, controller
would get another event of pausing due to controller cache refresh? This is to
make sure pause will not be lost immediately followed by a controller change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
