kaisun2000 commented on a change in pull request #1438:
URL: https://github.com/apache/helix/pull/1438#discussion_r500601815
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/TaskGarbageCollectionStage.java
##########
@@ -73,9 +73,12 @@ public void process(ClusterEvent event) throws Exception {
continue;
}
long purgeInterval = workflowConfig.getJobPurgeInterval();
+ if (purgeInterval <= 0) {
+ continue;
+ }
long currentTime = System.currentTimeMillis();
long nextPurgeTime = workflowContext.getLastJobPurgeTime() +
purgeInterval;
- if (purgeInterval > 0 && nextPurgeTime <= currentTime) {
Review comment:
I see due to this line:
```
scheduleNextJobPurge(workflowConfig.getWorkflowId(), nextPurgeTime,
_rebalanceScheduler,
manager);
```
previously it always schedule the purge.
Help me to understand the impact of this a little bit more. With this
change, event this is not always scheduled. From the perspective of flaky test,
it does not matter, right? I mean with this pull change, we will still see the
flaky test to be flaky.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
