NealSun96 commented on a change in pull request #1413:
URL: https://github.com/apache/helix/pull/1413#discussion_r501165058
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/dataproviders/BaseControllerDataProvider.java
##########
@@ -333,6 +370,7 @@ public synchronized void refresh(HelixDataAccessor
accessor) {
_stateModelDefinitionCache.refresh(accessor);
_clusterConstraintsCache.refresh(accessor);
updateMaintenanceInfo(accessor);
+ timeoutNodesDuringMaintenance(accessor, _clusterConfig,
_isMaintenanceModeEnabled);
Review comment:
Yes, because we want this step to be after updateMaintenanceInfo(),
which makes the most logical sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
