zhangmeng916 commented on a change in pull request #1449:
URL: https://github.com/apache/helix/pull/1449#discussion_r501244706
##########
File path:
helix-core/src/test/java/org/apache/helix/controller/changedetector/TestResourceChangeDetector.java
##########
@@ -438,7 +441,7 @@ public void testResetSnapshots() {
Assert.assertEquals(
changeDetector.getAdditionsByType(ChangeType.IDEAL_STATE).size() +
changeDetector
.getChangesByType(ChangeType.IDEAL_STATE).size() + changeDetector
- .getRemovalsByType(ChangeType.IDEAL_STATE).size(), 2);
+ .getRemovalsByType(ChangeType.IDEAL_STATE).size(), 1);
Review comment:
Does this number change mean what we previously tested was wrong? How to
justify the number change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
