kaisun2000 commented on a change in pull request #1455:
URL: https://github.com/apache/helix/pull/1455#discussion_r502130312
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/task/TaskTestUtil.java
##########
@@ -231,9 +239,17 @@ public static Date getDateFromStartTime(String startTime)
public static JobQueue.Builder buildJobQueue(String jobQueueName, int
delayStart,
Review comment:
There are other places to use this function. If we don't have this
signature, that means probably a lot of usage places are also changed. That is
not essential change, make it hard for people to reason and may be later to
revert.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
