jiajunwang commented on a change in pull request #1451:
URL: https://github.com/apache/helix/pull/1451#discussion_r502094542
##########
File path:
helix-rest/src/test/java/org/apache/helix/rest/server/TestClusterAccessor.java
##########
@@ -243,6 +243,7 @@ public void testAddConfigFields() throws IOException {
oldConfig.getRecord().update(configDelta.getRecord());
Assert.assertEquals(newConfig, oldConfig,
"cluster config from response: " + newConfig + " vs cluster config
actually: " + oldConfig);
+ System.out.println("new config:" + newConfig.toString());
Review comment:
+1
I see system out println quite a lot in your other PRs. If there is a
specific reason, please state. Otherwise, please avoid it. Otherwise, it will
distract the reviewers' attention and slow down the review process
unnecessarily.
##########
File path:
helix-rest/src/test/java/org/apache/helix/rest/server/TestClusterAccessor.java
##########
@@ -243,6 +243,7 @@ public void testAddConfigFields() throws IOException {
oldConfig.getRecord().update(configDelta.getRecord());
Assert.assertEquals(newConfig, oldConfig,
"cluster config from response: " + newConfig + " vs cluster config
actually: " + oldConfig);
+ System.out.println("new config:" + newConfig.toString());
Review comment:
+1
Also I see "system.out.println", instead of logging, quite a lot in your
other PRs. If there is a specific reason, please state. Otherwise, please avoid
it. Otherwise, it will distract the reviewers' attention and slow down the
review process unnecessarily.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
