NealSun96 opened a new pull request #1460:
URL: https://github.com/apache/helix/pull/1460
### Issues
- [x] My PR addresses the following Helix issues and references them in the
PR description:
Fixes #1459
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
If a reply message doesn't have a corresponding callback,
AsyncCallbackService will raise an exception when creating a handler for it.
Since stale reply messages may happen during participant reconnects, some
customers prefer handling them without raising an exception.
This PR changes behavior such that handlers are allowed to be created with
non-matched correlation ids, and no callback will be triggered when they are
handled. This PR also improves an old test case which didn't test certain
conditions correctly.
### Tests
- [x] The following tests are written for this issue:
```
[ERROR] Tests run: 1213, Failures: 1, Errors: 0, Skipped: 1, Time elapsed:
4,830.531 s <<< FAILURE! - in TestSuite
[ERROR]
testPeriodicRefresh(org.apache.helix.integration.spectator.TestRoutingTableProviderPeriodicRefresh)
Time elapsed: 2.031 s <<< FAILURE!
java.lang.AssertionError: expected:<4> but was:<3>
at
org.apache.helix.integration.spectator.TestRoutingTableProviderPeriodicRefresh.testPeriodicRefresh(TestRoutingTableProviderPeriodicRefresh.java:214)
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] TestRoutingTableProviderPeriodicRefresh.testPeriodicRefresh:214
expected:<4> but was:<3>
[INFO]
[ERROR] Tests run: 1213, Failures: 1, Errors: 0, Skipped: 1
[INFO]
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 01:20 h
[INFO] Finished at: 2020-10-12T16:36:07-07:00
[INFO]
------------------------------------------------------------------------
```
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following
wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their
subject lines. In addition, my commits follow the guidelines from "[How to
write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
