kaisun2000 commented on a change in pull request #1227:
URL: https://github.com/apache/helix/pull/1227#discussion_r504349597
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/rebalancer/CrushRebalancers/TestCrushAutoRebalance.java
##########
@@ -298,7 +298,7 @@ private void validateZoneAndTagIsolation(IdealState is,
ExternalView ev, int exp
Assert.assertEquals(assignedZones.size(), expectedReplica);
}
}
-
+/* These blank test would cause @AfterClass not get invoked.
Review comment:
You are right. It is delayed after some other test class run. Still,
this means hard to track leaking threads, as we want to have all test method in
one test class to run at one batch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
