NealSun96 commented on a change in pull request #1460:
URL: https://github.com/apache/helix/pull/1460#discussion_r504884937
##########
File path:
helix-core/src/main/java/org/apache/helix/messaging/handling/AsyncCallbackService.java
##########
@@ -62,15 +62,6 @@ void verifyMessage(Message message) {
throw new HelixException(errorMsg);
}
Review comment:
You brought up a very good point, although for our scenario, ZK read
probably fails before an effective DOS. I understand this reminds you of some
TCP DOS. :)
If you could check out `HelixTaskExecutor`, at around line 900, you can see
how we handle null return value for `createHandler()`. The current approach is
to skip the message without cleaning it up. I could explore on changing this
current approach (because we need to clean up those reply messages), but such a
change will impact other message handlings as well (such as state transition
messages).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
