jiajunwang commented on a change in pull request #1429:
URL: https://github.com/apache/helix/pull/1429#discussion_r509711435
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/api/client/RealmAwareZkClient.java
##########
@@ -261,8 +261,11 @@ void asyncSetData(final String path, Object datat, final
int version,
long getCreationTime(String path);
+ @Deprecated
List<OpResult> multi(final Iterable<Op> ops);
Review comment:
This operation does not fit the Helix ZkClient design since,
1. there is no retry until connecting support.
2. there is no metric support.
Keep supporting it, then we need to take it as a very special case.
Currently, there is no large scale usage, so the metrics and caller logic looks
fine. Otherwise, we will see issues here and there.
So my take is that we want to replace it with the new multiops API with full
support.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
