kaisun2000 commented on a change in pull request #1451:
URL: https://github.com/apache/helix/pull/1451#discussion_r509790297



##########
File path: 
helix-rest/src/test/java/org/apache/helix/rest/server/TestClusterAccessor.java
##########
@@ -259,7 +259,15 @@ public void testUpdateConfigFields() throws IOException {
     record.getSimpleFields().clear();
     record.setSimpleField(key, value + "--updated");
 
-    key = record.getListFields().keySet().iterator().next();
+    // skip INSTANCE_CAPACITY_KEYS which can be added by waged rebalancer in 
global run

Review comment:
       @jiajunwang, I think your theory is not right. The following is 
dependency trail. 
   
   >testEnableWagedRebalanceForAllResources ->
   testActivateSuperCluster ->
   testGetStateModelDef ->
   testEnableDisableMaintenanceModeWithCustomFields ->
   testGetMaintenanceHistory ->
   testGetControllerLeadershipHistory ->
   testEnableDisableMaintenanceMode ->
   testGetClusterConfig ->
   testEnableDisableCluster ->
   testCreateDeleteCluster ->
   testDeleteConfigFields ->
   testUpdateConfigFields 
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to