narendly commented on a change in pull request #1480:
URL: https://github.com/apache/helix/pull/1480#discussion_r509863907
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/server/ServerContext.java
##########
@@ -157,6 +158,50 @@ public RealmAwareZkClient getRealmAwareZkClient() {
return _zkClient;
}
+ /**
+ * Returns a RealmAWareZkClient with ByteArraySerializer with double-checked
locking.
+ * NOTE: this is different from getRealmAwareZkClient in that it does not
reset listeners for
+ * _zkClientForListener because this RealmAwareZkClient is independent from
routing data changes.
+ * @return
+ */
+ public RealmAwareZkClient getByteArrayRealmAwareZkClient() {
Review comment:
I agree with the suggestions made here. This PR has been updated with
the refactor. @jiajunwang the serializer is not the only thing that differs,
but I pulled some trick to make it work to cut down on duplication.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
