jiajunwang commented on a change in pull request #1072:
URL: https://github.com/apache/helix/pull/1072#discussion_r511016147
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/constant/ZkSystemPropertyKeys.java
##########
@@ -60,4 +60,7 @@
*/
public static final String ZK_AUTOSYNC_ENABLED =
"zk.zkclient.autosync.enabled";
+
+ /** System property key for jute.maxbuffer */
Review comment:
Zookeeper has this String def since 3.5.2. It is in class ZKConfig.java.
Please add a TODO here so we can use this one after we bump up the ZK version.
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java
##########
@@ -2492,4 +2500,15 @@ private void checkNumChildrenLimit(String path) throws
KeeperException {
stat.getNumChildren(), NUM_CHILDREN_LIMIT);
}
}
+
+ private void validateWriteSizeLimitConfig() {
+ int serializerSize = ZNRecordUtil.getSerializerWriteSizeLimit();
+ LOG.info("ZNRecord serializer write size limit: {}; ZkClient write size
limit: {}",
+ serializerSize, WRITE_SIZE_LIMIT);
+ // ZNRecord serializer write size limit should not be set greater than
size limit in ZkClient
Review comment:
nit, but I prefer not to repeat the message that has been mentioned in
the exception in the code comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
