jiajunwang commented on a change in pull request #1489:
URL: https://github.com/apache/helix/pull/1489#discussion_r513732287
##########
File path:
helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java
##########
@@ -192,43 +191,38 @@ public void registerMessageHandlerFactory(String type,
MessageHandlerFactory fac
@Override
public void registerMessageHandlerFactory(String type, MessageHandlerFactory
factory,
int threadpoolSize) {
- if (factory instanceof MultiTypeMessageHandlerFactory) {
+ if (factory instanceof MultiTypeMessageHandlerFactory) {
if (!((MultiTypeMessageHandlerFactory)
factory).getMessageTypes().contains(type)) {
throw new HelixException("Message factory type mismatch. Type: " +
type + ", factory: "
+ ((MultiTypeMessageHandlerFactory) factory).getMessageTypes());
}
} else {
if (!factory.getMessageType().equals(type)) {
throw new HelixException(
- "Message factory type mismatch. Type: " + type + ", factory: " +
factory.getMessageType());
+ "Message factory type mismatch. Type: " + type + ", factory: " +
factory
+ .getMessageType());
Review comment:
This PR is all about non-essential changes that are the preparation for
the real business logic changes.
Non-essential does not mean we are not going to do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
