lei-xia commented on a change in pull request #1487:
URL: https://github.com/apache/helix/pull/1487#discussion_r513821364
##########
File path: helix-core/src/main/java/org/apache/helix/util/StatusUpdateUtil.java
##########
@@ -55,6 +56,12 @@
public class StatusUpdateUtil {
static Logger _logger = LoggerFactory.getLogger(StatusUpdateUtil.class);
+ public static final boolean ERROR_LOG_TO_ZK_ENABLED;
+ static {
+ String valueString =
System.getProperty(SystemPropertyKeys.STATEUPDATEUTIL_ERROR_LOG_ENABLED, "");
+ ERROR_LOG_TO_ZK_ENABLED = valueString.equals("enabled") ? true : false;
Review comment:
Please use HelixUtil.getSystemPropertyAsBoolean(), it allows you to
specify the default value there in the method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
