jiajunwang commented on a change in pull request #1500:
URL: https://github.com/apache/helix/pull/1500#discussion_r516992216
##########
File path:
helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java
##########
@@ -613,7 +613,12 @@ void reset() {
MsgHandlerFactoryRegistryItem item = _hdlrFtyRegistry.get(msgType);
if (item.factory() != null) {
- item.factory().reset();
+ try {
+ item.factory().reset();
+ } catch (Exception ex) {
Review comment:
This is only called when we clean up. All the paths lead to the
termination of the executor. The only result of not swallowing the exception is
that the later cleanup steps will not happen.
Backtrace is a good point. I think I missed it unintentionally. Thanks for
pointing this out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
