xyuanlu opened a new pull request #1511:
URL: https://github.com/apache/helix/pull/1511
### Issues
- [X] My PR addresses the following Helix issues and references them in the
PR description:
#1510- Improve debuggability in Task Framework
### Description
- [X] Here are some details about my PR, including screenshots of any UI
changes:
While debugging, sometimes it is hard to track down the problem with current
log statement. We would like to improve logging in Task Framework.
This PR improves log format for better debuggability and potential
performance improvement for the following 3 files.
helix-core/src/main/java/org/apache/helix/task/AbstractTaskDispatcher.java
helix-core/src/main/java/org/apache/helix/task/JobDispatcher.java
helix-core/src/main/java/org/apache/helix/task/WorkflowDispatcher.java
### Tests
- [X] The following tests are written for this issue:
NA
- [X] The following is the result of the "mvn test" command on the
appropriate module:
```
[ERROR] Failures:
[ERROR] TestWagedRebalance.testRebalanceTool:220 Maps do not match for
key:localhost_12918 actual:MASTER expected:SLAVE expected:<SLAVE> but
was:<MASTER>
[INFO]
[ERROR] Tests run: 1244, Failures: 1, Errors: 0, Skipped: 0
[INFO]
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 01:24 h
[INFO] Finished at: 2020-11-04T19:30:26-08:00
[INFO]
------------------------------------------------------------------------
rerun
[INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
85.979 s - in
org.apache.helix.integration.rebalancer.WagedRebalancer.TestWagedRebalance
```
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following
wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their
subject lines. In addition, my commits follow the guidelines from "[How to
write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
