narendly commented on a change in pull request #1532:
URL: https://github.com/apache/helix/pull/1532#discussion_r523830984
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateOutput.java
##########
@@ -108,4 +108,12 @@ public void setPreferenceLists(String resource,
protected boolean containsResource(String resource) {
return _preferenceLists != null && _preferenceLists.containsKey(resource);
}
+
+ @Override
+ public String toString() {
+ StringBuilder sb = new StringBuilder();
+ sb.append("preference list= ").append(_preferenceLists);
+ sb.append(", resourceStateMap= ").append(_resourceStateMap);
+ return sb.toString();
+ }
Review comment:
Are we printing/logging this? If so, I don't think that's wise since
that would be a lot of text being logged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
