zhangmeng916 commented on a change in pull request #1537:
URL: https://github.com/apache/helix/pull/1537#discussion_r525535972
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/messaging/TestP2PNoDuplicatedMessage.java
##########
@@ -174,7 +174,10 @@ public void testP2PStateTransitionEnabled() {
verifyP2PEnabled(startTime);
}
- Assert.assertEquals(p2pTrigged, total);
+ // The success rate really depends on how quick participant act in
relationship with controller.
+ // For now, we set 90% threshold.
+ long threshold = Math.round(total * 0.9);
Review comment:
I think we cannot guarantee 100% P2P for all kinds of infrastructure.
Although local tests always passed, there're some failures in our testing
environment. The percent is always above 90% though. I believe there are corner
cases that we cannot label all stale messages, which will block the sending of
P2P.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
