pkuwm commented on a change in pull request #1526:
URL: https://github.com/apache/helix/pull/1526#discussion_r538743321
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkConnection.java
##########
@@ -192,4 +234,59 @@ public String getServers() {
public void addAuthInfo(String scheme, byte[] auth) {
_zk.addAuthInfo(scheme, auth);
}
+
+ private void lookupGetChildrenMethod() {
Review comment:
Thanks, @kaisun2000 for the clarification!
I don’t think we have to do this. Firstly, we are solving the case for
internal use cases. So we have our own ZK with pagination. Helix is by default
still using apache ZK.
If the external users customize their ZK by directly using the original
patch, I don’t think they would expect helix to be compatible with their custom
ZK. So Helix will still call the non-paginated getChildren API that is supposed
to be in their custom ZK. If they really want the pagination API in helix, it's
recommended to use linkedin ZK or our patch, so helix will be compatible with
that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
