pkuwm commented on a change in pull request #1526:
URL: https://github.com/apache/helix/pull/1526#discussion_r546010841
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkConnection.java
##########
@@ -36,16 +38,23 @@
import org.apache.zookeeper.ZooKeeper.States;
import org.apache.zookeeper.data.ACL;
import org.apache.zookeeper.data.Stat;
-
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
public class ZkConnection implements IZkConnection {
- private static final Logger LOG = Logger.getLogger(ZkConnection.class);
+ private static final Logger LOG =
LoggerFactory.getLogger(ZkConnection.class);
/** It is recommended to use quite large sessions timeouts for ZooKeeper. */
private static final int DEFAULT_SESSION_TIMEOUT = 30000;
+ // A config to force disabling using ZK's paginated getChildren.
+ // By default the value is false.
+ private static final boolean GETCHILDREN_PAGINATION_DISABLED =
Review comment:
It won't have a problem. If server does not support the feature, it will
handle the `UnimplementedException` from server and fallback to the
non-paginated API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
