NealSun96 opened a new pull request #1730:
URL: https://github.com/apache/helix/pull/1730
### Issues
- [x] My PR addresses the following Helix issues and references them in the
PR description:
Fixes #1729
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
`getAssignmentForWagedFullAutoImpl` doesn't correctly assign a snapshot to
the read-only rebalancer before applying the parameters as a new snapshot. That
means when the Waged rebalancer compares snapshots, it always treats every bit
of metadata from the parameters as new metadata since the old snapshot is
missing, therefore it always triggers a complete global rebalance as if the
cluster is newly created.
This isn't the intended behavior. The intended behavior is that
`getAssignmentForWagedFullAutoImpl` acts as a simulation - the parameters are
as if applied without actually applying them, and the Waged rebalancer reaction
can be observed. To correctly simulate, the read-only rebalancer must have an
old snapshot that aligns with the current metadata of the cluster, so it can
react to metadata changes properly - for example, if the difference between
current metadata and the parameters only contains 1 ResourceConfig change, the
global rebalance should only affect that resource.
### Tests
- The following is the result of the "mvn test" command on the appropriate
module:
```
[ERROR] Tests run: 1265, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
5,250.877 s <<< FAILURE! - in TestSuite
[ERROR]
testLostZkConnection(org.apache.helix.integration.TestZkConnectionLost) Time
elapsed: 127.742 s <<< FAILURE!
org.apache.helix.HelixException: Workflow
testLostZkConnection_20210508T023618 context is empty or not in states:
[COMPLETED], current state: IN_PROGRESS.
at
org.apache.helix.integration.TestZkConnectionLost.testLostZkConnection(TestZkConnectionLost.java:174)
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] TestZkConnectionLost.testLostZkConnection:174 ยป Helix Workflow
testLostZkConne...
[INFO]
[ERROR] Tests run: 1265, Failures: 1, Errors: 0, Skipped: 0
[INFO]
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 01:27 h
[INFO] Finished at: 2021-05-07T20:00:29-07:00
[INFO]
------------------------------------------------------------------------
```
```
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
79.922 s - in org.apache.helix.integration.TestZkConnectionLost
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] --- jacoco-maven-plugin:0.8.6:report (generate-code-coverage-report)
@ helix-core ---
[INFO] Loading execution data file
/home/nesun/helix/helix-core/target/jacoco.exec
[INFO] Analyzed bundle 'Apache Helix :: Core' with 890 classes
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 01:30 min
[INFO] Finished at: 2021-05-10T11:11:38-07:00
[INFO]
------------------------------------------------------------------------
```
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous
assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also
include these changes in merge description so that other developers are aware
of these changes. This allows them to make relevant code changes in feature
branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following
wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their
subject lines. In addition, my commits follow the guidelines from "[How to
write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
